New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game no longer crashes if no ResourceLayer is used. #14088

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
5 participants
@IceReaper
Contributor

IceReaper commented Sep 29, 2017

For my mod i have a totally different resource system and do not need the resource layer at all.
However these two Traits do not work if the ResourceLayer trait is not present.
Their behavior should be unaffected whether this trait is enabled or not, as its absence should result in the same behavior as its use-case.
Adding the ResourceLayer would require to also add ResourceType which again requires you to define at last one type, etc...
This huge stack of Traits and configuration could be prevented by simply loosening these two requirements.
The other traits which depend on the ResourceLayer trait were not changed, because they are actual resource based traits (like the harvester code) .

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Sep 29, 2017

Member

It would be good if we could decouple these from ResourceLayer completely by introducing a new interface (IBuildingBlockingLayer?). This would then let mods introduce other blocking types if they need them.

Member

pchote commented Sep 29, 2017

It would be good if we could decouple these from ResourceLayer completely by introducing a new interface (IBuildingBlockingLayer?). This would then let mods introduce other blocking types if they need them.

@reaperrr reaperrr merged commit 4e45747 into OpenRA:bleed Oct 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Oct 6, 2017

Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/c81c70f0c29ded8b9ab339789527685157c1d9a3...e7c20f4643202da6f4d34bab728d290de8204c22

We already have too many PRs sitting idle, so I felt in this case merging the PR and filing a follow-up ticket would be the better approach: #14133

Contributor

reaperrr commented Oct 6, 2017

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/c81c70f0c29ded8b9ab339789527685157c1d9a3...e7c20f4643202da6f4d34bab728d290de8204c22

We already have too many PRs sitting idle, so I felt in this case merging the PR and filing a follow-up ticket would be the better approach: #14133

@IceReaper IceReaper deleted the IceReaper:no_ResourceLayer branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment