New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the devastator lint warnings #14137

Merged
merged 2 commits into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@abcdefg30
Member

abcdefg30 commented Oct 7, 2017

OpenRA.Utility(1,1): Warning: Actor type devastator grants conditions that are not consumed: notmobile

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Oct 8, 2017

Member

The Carryable trait needs to be disabled by the overload condition, otherwise you can exploit these as flying bombs. Can you please fix that here too?

Member

pchote commented Oct 8, 2017

The Carryable trait needs to be disabled by the overload condition, otherwise you can exploit these as flying bombs. Can you please fix that here too?

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Oct 8, 2017

Member

You could only blow your own repair pad up, :P but okay 'fixed' that as well.

Member

abcdefg30 commented Oct 8, 2017

You could only blow your own repair pad up, :P but okay 'fixed' that as well.

@pchote

pchote approved these changes Oct 8, 2017

@pchote pchote merged commit 4bca0c4 into OpenRA:bleed Oct 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:devastator branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment