New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove directory creation side effect from Platform.SupportDir. #14152

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Oct 8, 2017

Fixes #14131.

This was old dead code, and removing it appears to have no regressions aside from the support dir metadata registration which is fixed here.

Things I have tested:

  • Running the game with no support dir (support dir is created when needed)
  • Installing the deb package (support dir is not created, system metadata installed)
  • Installing the Windows package (support dir is not created, system metadata installed)
  • Running lint tests (behaves as expected):
    • Support dir is created on current branch, but only because it is based before #13938.
    • When rebased on a fixed version of #14136 the support dir is not created.
  • Running unit tests (support dir is not created, runs as expected)
  • Running mod metadata registration / deregistration (support dir is created when needed)

@pchote pchote added this to the Next Release milestone Oct 8, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Oct 8, 2017

Contributor

Things I've tested and confirmed:

  • Running the game with no support dir (support dir is created when needed)
  • Installing the Windows package (support dir is not created, system metadata installed)
  • Running lint tests (behaves as expected):
    Support dir is created on current branch, but only because it is based before #13938.

👍 from me.

Contributor

reaperrr commented Oct 8, 2017

Things I've tested and confirmed:

  • Running the game with no support dir (support dir is created when needed)
  • Installing the Windows package (support dir is not created, system metadata installed)
  • Running lint tests (behaves as expected):
    Support dir is created on current branch, but only because it is based before #13938.

👍 from me.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Oct 8, 2017

Member

Rebased on top of the lint test fixes.

Member

pchote commented Oct 8, 2017

Rebased on top of the lint test fixes.

@abcdefg30

Seems to work fine.

@abcdefg30 abcdefg30 merged commit f96c271 into OpenRA:bleed Oct 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Oct 8, 2017

@pchote pchote deleted the pchote:fix-supportdir-creation branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment