New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification sound when paratroopers land #14161

Merged
merged 1 commit into from Oct 14, 2017

Conversation

Projects
None yet
4 participants
@gkaretka
Contributor

gkaretka commented Oct 11, 2017

@@ -112,6 +115,10 @@ public Actor[] SendParatroopers(Actor self, WPos target, bool randomize = true,
});
}
if (!aircraftInRange.Any(kv => kv.Value))

This comment has been minimized.

@Phrohdoh

Phrohdoh Oct 11, 2017

Member

Play the notifications when the aircraft isn't in range of the lz?

@Phrohdoh

Phrohdoh Oct 11, 2017

Member

Play the notifications when the aircraft isn't in range of the lz?

This comment has been minimized.

@pchote

pchote Oct 11, 2017

Member

This is false when the first aircraft enters the area - it gets set to true just below.

@pchote

pchote Oct 11, 2017

Member

This is false when the first aircraft enters the area - it gets set to true just below.

@pchote

pchote approved these changes Oct 14, 2017

@pchote pchote added the PR: Needs +2 label Oct 14, 2017

@reaperrr reaperrr merged commit 97e0f17 into OpenRA:bleed Oct 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment