New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Add Harkonnen Mission 6a #14164

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
5 participants
@MustaphaTR
Member

MustaphaTR commented Oct 12, 2017

No description provided.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Oct 12, 2017

Contributor

OpenRA.Utility(1,1): Error: Allies contains player Ordos Main Base Main Base that is not in list.

Contributor

reaperrr commented Oct 12, 2017

OpenRA.Utility(1,1): Error: Allies contains player Ordos Main Base Main Base that is not in list.

@ltem

ltem approved these changes Oct 15, 2017

Couldn't spot any difference to the gruntmod version of the mission (which took me way too long to finish due to windows 10 + gruntsmod issues :S ). Also the map and the lua code is fine, so I approve this PR 👍.

Funfact and not relevant for the review: It seems, at least I think so, that the small Ordos base was original planed as a Atreides base and these factions would be allies during this mission. If you render (gruntmods tools) the map it still has Atreides structures and the victory voice line back at the main screen (something like "The alliance was broken") makes more sense, if there was an actual alliance during the mission.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Oct 15, 2017

Member

It is actually Fremen Base in the editor, not Atreides. That's how original mapping style works, i don't think this has anything to do with old plans.

Member

MustaphaTR commented Oct 15, 2017

It is actually Fremen Base in the editor, not Atreides. That's how original mapping style works, i don't think this has anything to do with old plans.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Oct 15, 2017

Contributor

Ups, well, I only looked at the structures ^^ and thought it would be a fitting interpretation.

Contributor

ltem commented Oct 15, 2017

Ups, well, I only looked at the structures ^^ and thought it would be a fitting interpretation.

@pchote pchote added the PR: Needs +2 label Oct 15, 2017

@reaperrr reaperrr merged commit bfe540c into OpenRA:bleed Nov 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 3, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-harkonnen-6a branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment