Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Create a trait that grants a condition on actor creation #14216
3 times, most recently
Oct 19, 2017
This is absolutely NOT modder friendly however. I'm aware @pchote propagated this for a good while now, but this is just another tunnel vision reimplementation with limited modding options compared to the original, akin to how the TS EMP Cannon turned out.
Sure, conditions might be the future and all that, but due to the sheer amount of visual offsets defined in yaml trait codes (turret offsets, firing offsets), actor variations cannot be done effectively via random conditions - this limits their use and requires really finicky yaml code to reach the level of complexity Generals could do.
Take note that Generals could also spawn entirely different units as variations - a good example is the Rise of the Reds Propaganda Airship's Trollship variant, which won't even get selected with the "select all of this unit's type" button, because it isn't defined as a mere variation.
Footnote: this was the feature which pushed me to start my soft-fork - as I said back at #12554 (comment) - , because I realized AttacqueSuperior#18 wouldn't be "compliant" and favorable over this solution even though it would actually be able to do everything Generals could and allow YAML deduplication via creating an unit template for inheritance and individual variants would only need to define offsets/variant codes.
My real issue with it is that it works "like in Generals" yet it can't be used to spawn completely different actors or allow mappers to choose a variant statically either - which Generals could do. These are just arbitrary limits introduced for no reason - and actually hurts usability more than a default magic value on a trait.
I don't believe it is simpler to use for simple cases either - it is simpler to use if you don't rely on trait conditions a lot and don't have as complicated gameplay mechanics as Generals had (I might be doing it wrong, but I am already at the level where I'm creating shim conditions to simplify my trait setups, because no way I'd write rank-level || empdisable || weaponjammer || temporal || paradrop for all weapons defined and just shim emp-temporal-weaponjammers-paradrop to a weapondisable onto a template).
Feel free taking that other option suggested on the IRC anyway. That's a clearly working solution to the issue I present. It's working for good months now afterall.
This was how I intended people to handle complicated situations, so