New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Unit Ready" notification playing erroneously #14221

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
5 participants
@abcdefg30
Member

abcdefg30 commented Oct 19, 2017

Testcase: Build a barracks and block the entries. Produce a unit (will be blocked on "Ready") and then sell the structure. Without this fix the "Unit Ready" sound is played.

Note that BuildUnit is only ever used here, so this change should change any other behavior.

@penev92

👍

@Smittytron

Works as advertised.

@AndriiYukhymchak

Just wow... Who put true there and why? LGTM

@pchote

pchote approved these changes Oct 25, 2017

@pchote pchote merged commit cba7c60 into OpenRA:bleed Oct 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:unitReady branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment