New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValidStances, TargetTypes, and RevealDisguiseType.Move to Disguise. #14236

Merged
merged 3 commits into from Nov 3, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Oct 21, 2017

A cleaned up reimplementation of #13578.

void ITick.Tick(Actor self)
{
if (info.RevealDisguiseOn.HasFlag(RevealDisguiseType.Move) && lastPos != null && lastPos.Value != self.Location)

This comment has been minimized.

@penev92

penev92 Oct 21, 2017

Member

I am not a fan of this approach. Isn't this exactly why we have IMove.IsMoving?
Also this will trigger a drop of disguise on teleport or similar force-move, which might be an unwanted side effect, while IsMoving won't.

@penev92

penev92 Oct 21, 2017

Member

I am not a fan of this approach. Isn't this exactly why we have IMove.IsMoving?
Also this will trigger a drop of disguise on teleport or similar force-move, which might be an unwanted side effect, while IsMoving won't.

This comment has been minimized.

@GraionDilach
@GraionDilach

GraionDilach Oct 22, 2017

Contributor

This comment has been minimized.

@penev92

penev92 Oct 22, 2017

Member

Then I'm not a fan of that one either :D
My question stands: can't we use IMove.IsMoving and if we can, why aren't we?

@penev92

penev92 Oct 22, 2017

Member

Then I'm not a fan of that one either :D
My question stands: can't we use IMove.IsMoving and if we can, why aren't we?

This comment has been minimized.

@pchote

pchote Oct 22, 2017

Member

IMove.IsMoving has never worked properly. It has recently-ish been improved, but at least #11885 is still a problem.

@pchote

pchote Oct 22, 2017

Member

IMove.IsMoving has never worked properly. It has recently-ish been improved, but at least #11885 is still a problem.

@penev92

👍

@reaperrr reaperrr merged commit 4dba9f5 into OpenRA:bleed Nov 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:spy-move branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment