New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow remaining time to be hidden in ProductionPaletteWidget. #14268

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@IceReaper
Contributor

IceReaper commented Oct 25, 2017

This allows mods to rely fully on the clock and hide the remaining time from the ProductionPaletteWidget.

@@ -64,6 +64,8 @@ public enum ReadyTextStyleOptions { Solid, AlternatingColor, Blinking }
public readonly string NotBuildableSequence = "idle";
public readonly string NotBuildablePalette = "chrome";
public readonly bool DrawTime = true;

This comment has been minimized.

@pchote

pchote Oct 25, 2017

Member

It might make sense to expose multiple flags, or have it as an enum, allowing control of all three label types?

@pchote

pchote Oct 25, 2017

Member

It might make sense to expose multiple flags, or have it as an enum, allowing control of all three label types?

This comment has been minimized.

@IceReaper

IceReaper Oct 25, 2017

Contributor

it doesnt make much sense for the build / queue amount, as there is no other way to display that information. the other strings can simply be set to emptystring, so no special function is required.

@IceReaper

IceReaper Oct 25, 2017

Contributor

it doesnt make much sense for the build / queue amount, as there is no other way to display that information. the other strings can simply be set to emptystring, so no special function is required.

@pchote

pchote approved these changes Oct 25, 2017

@pchote pchote added the PR: Needs +2 label Oct 25, 2017

@reaperrr reaperrr merged commit 88c94ee into OpenRA:bleed Oct 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Oct 25, 2017

@IceReaper IceReaper deleted the IceReaper:HideableProductionPaletteWidgetTime branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment