New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Original Remap Palette for RA Campaign #14277

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Projects
None yet
6 participants
@MustaphaTR
Member

MustaphaTR commented Oct 30, 2017

,Co-Op Missions and Shellmap.

@MustaphaTR MustaphaTR referenced this pull request Nov 10, 2017

Open

RA campaigns polish + unifying #12806

0 of 5 tasks complete
@Arular101

Arular101 approved these changes Nov 10, 2017 edited

👍

I really like this change. It brings the colors back to how the original game was.

I tested the campaign and saw that in some missions the colors aren't right. However, this has noting to do with this PR.

palette 1

Soviets 02a and b
palette s2

Soviets 03
palette s3

Soviets 05
palette 2

These changes should be made:
Allies 02: convoy trucks.
Allies 03b: ranger.
Soviets 02a and b: enemy color.
Soviets 03: enemy and own color.
Soviets 05: some enemy units and the base that gets build on the island.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 11, 2017

Member

My RA1 installation didn't have missions in it, so i'm installing currently and will test the stuff to be sure.

Allies 03b: ranger.

I'm not sure what exactly going on there, ranger is owned by neutral on OpenRA, i'll check how was it in original.

Allies 02: convoy trucks.
Soviets 02a and b: enemy color.
Soviets 03: enemy

Either WW has colors changes specifically for those missions, or someone messed the faction names up during conversion, will check.

Soviets 03: own color.
Soviets 05: some enemy units and the base that gets build on the island.

These are my fault, i forgot to add colors of GoodGuy and BadGuy player names.

Soviets 05: Radar Dome

Radar is owned by Greece in this mission for OpenRA, probably changed so it won't show black low power overlay. Some .yaml editing can fix the problem.

Member

MustaphaTR commented Nov 11, 2017

My RA1 installation didn't have missions in it, so i'm installing currently and will test the stuff to be sure.

Allies 03b: ranger.

I'm not sure what exactly going on there, ranger is owned by neutral on OpenRA, i'll check how was it in original.

Allies 02: convoy trucks.
Soviets 02a and b: enemy color.
Soviets 03: enemy

Either WW has colors changes specifically for those missions, or someone messed the faction names up during conversion, will check.

Soviets 03: own color.
Soviets 05: some enemy units and the base that gets build on the island.

These are my fault, i forgot to add colors of GoodGuy and BadGuy player names.

Soviets 05: Radar Dome

Radar is owned by Greece in this mission for OpenRA, probably changed so it won't show black low power overlay. Some .yaml editing can fix the problem.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 11, 2017

Member

Updated.

Allies 02: convoy trucks.

Replaced France with England, which fixes the colors.

Allies 03b: ranger.

Added an England player and given the Ranger to it.

Soviets 02a and b: enemy color.
Soviets 03: enemy

Replaced Germany with Greece, which fixes the colors.

Soviets 03: own color.

Renamed Soviet to BadGuy, and Added BadGuy to campaign-palettes.yaml.

Soviets 05: some enemy units and the base that gets build on the island.

Added GoodGuy to campaign-palettes.yaml.

Soviets 05: Radar Dome

Added a France player and given Radar Dome to it. Removed WithColoredOverlay@IDISABLE: from Radar Dome.

Edit: I just realised what i did to Radar Dome low power overlay is not really a good way (as Player can also build a Radar Dome), i'll try something else. Edit 2: Updated again, this should work fine.

Member

MustaphaTR commented Nov 11, 2017

Updated.

Allies 02: convoy trucks.

Replaced France with England, which fixes the colors.

Allies 03b: ranger.

Added an England player and given the Ranger to it.

Soviets 02a and b: enemy color.
Soviets 03: enemy

Replaced Germany with Greece, which fixes the colors.

Soviets 03: own color.

Renamed Soviet to BadGuy, and Added BadGuy to campaign-palettes.yaml.

Soviets 05: some enemy units and the base that gets build on the island.

Added GoodGuy to campaign-palettes.yaml.

Soviets 05: Radar Dome

Added a France player and given Radar Dome to it. Removed WithColoredOverlay@IDISABLE: from Radar Dome.

Edit: I just realised what i did to Radar Dome low power overlay is not really a good way (as Player can also build a Radar Dome), i'll try something else. Edit 2: Updated again, this should work fine.

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 11, 2017

Contributor

Oh sorry, I forgot to mention that the radar dome in Soviets 05 could stay blue. In my opinion that is fine. I let it up to you if you want to change it to green or let it stay blue.

Contributor

Arular101 commented Nov 11, 2017

Oh sorry, I forgot to mention that the radar dome in Soviets 05 could stay blue. In my opinion that is fine. I let it up to you if you want to change it to green or let it stay blue.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 11, 2017

Member

I already changed it to French colors and is working fine. I'm just unsure if my approach is correct.

Member

MustaphaTR commented Nov 11, 2017

I already changed it to French colors and is working fine. I'm just unsure if my approach is correct.

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 12, 2017

Contributor

Again great job at fixing it so fast! I tested the above mentioned changes and all are good now. I also tested the radar dome in Soviet 05 and the only thing I can say is that it works function wise. I can't say if the approach is good or not.

I tested the rest of the mission and all looks good, but I have to say I only tested the beginnings of these missions. That's because, I haven't played these missions yet and I want to play co-op with a friend without knowing the mission. The thing what I'm not sure is the third Allied faction in the missions Evacuation, Exodus and Infiltration.
palette 5

Only the co-op person in Evacuation, Exodus and Infiltration and survival 01 and 02 are a slightly different green. To me it is fine, so 👍 and it's got to be said, the green in Evacuation, Exodus and Infiltration is really nice!

Contributor

Arular101 commented Nov 12, 2017

Again great job at fixing it so fast! I tested the above mentioned changes and all are good now. I also tested the radar dome in Soviet 05 and the only thing I can say is that it works function wise. I can't say if the approach is good or not.

I tested the rest of the mission and all looks good, but I have to say I only tested the beginnings of these missions. That's because, I haven't played these missions yet and I want to play co-op with a friend without knowing the mission. The thing what I'm not sure is the third Allied faction in the missions Evacuation, Exodus and Infiltration.
palette 5

Only the co-op person in Evacuation, Exodus and Infiltration and survival 01 and 02 are a slightly different green. To me it is fine, so 👍 and it's got to be said, the green in Evacuation, Exodus and Infiltration is really nice!

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 12, 2017

Member

Monster Tank Madness is a mission from Aftermath expansion. All other coop and survival missions were probably also trying to imitate the original colors, so changes to these colors are what should happen.

Member

MustaphaTR commented Nov 12, 2017

Monster Tank Madness is a mission from Aftermath expansion. All other coop and survival missions were probably also trying to imitate the original colors, so changes to these colors are what should happen.

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 12, 2017

Contributor

Monster Tank Madness is a mission from Aftermath expansion.

Yup, this one I played and is 100% correct.

By the way, is there a way to get these colors in skirmish/multiplayer?

Contributor

Arular101 commented Nov 12, 2017

Monster Tank Madness is a mission from Aftermath expansion.

Yup, this one I played and is 100% correct.

By the way, is there a way to get these colors in skirmish/multiplayer?

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 15, 2017

Member

Needs a rebase.

Member

pchote commented Nov 15, 2017

Needs a rebase.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 15, 2017

Member

Rebased.

Member

MustaphaTR commented Nov 15, 2017

Rebased.

@pchote pchote added PR: Needs +2 and removed PR: Rebase me! labels Nov 15, 2017

Show outdated Hide outdated mods/ra/maps/soviet-05/rules.yaml Outdated
@Arular101

👍 Perfect!

I just would like to know if there are intentions to bring the original palette to the rest of the game.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Nov 18, 2017

Contributor

I wouldn't bring the original colors to skirmish/multiplayer - there were only 8 colors afterall and we ship maps with 12 players.

Contributor

GraionDilach commented Nov 18, 2017

I wouldn't bring the original colors to skirmish/multiplayer - there were only 8 colors afterall and we ship maps with 12 players.

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 18, 2017

Contributor

Oh yeah, I was thinking about the same palettes will be used for all the colors (the buildings look a little bit shinier, most noticeable on the roof of the war factory), but I guess that is not easy to implement.

Contributor

Arular101 commented Nov 18, 2017

Oh yeah, I was thinking about the same palettes will be used for all the colors (the buildings look a little bit shinier, most noticeable on the roof of the war factory), but I guess that is not easy to implement.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 19, 2017

Member

Either WW has colors changes specifically for those missions, or someone messed the faction names up during conversion, will check.

You replaced the factions in our versions, but didn't confirm which of these was the case. I'm assuming it was the latter?

Member

pchote commented Nov 19, 2017

Either WW has colors changes specifically for those missions, or someone messed the faction names up during conversion, will check.

You replaced the factions in our versions, but didn't confirm which of these was the case. I'm assuming it was the latter?

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 19, 2017

Member

Yes, latter. Whoever made those missions for OpenRA used different names for factions than original.

Member

MustaphaTR commented Nov 19, 2017

Yes, latter. Whoever made those missions for OpenRA used different names for factions than original.

@reaperrr reaperrr merged commit 01c1e08 into OpenRA:bleed Nov 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 19, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:ra-campaign-palette branch Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment