New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont show refund text if Sellable: trait is disabled. #14285

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
4 participants
@MustaphaTR
Member

MustaphaTR commented Nov 3, 2017

Small thing i noticed while working on RA Classic.

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 4, 2017

Member

I know this may sound petty, but can you please make it
if (!IsTraitDisabled && self.World.OrderGenerator is SellOrderGenerator) instead?

Member

penev92 commented Nov 4, 2017

I know this may sound petty, but can you please make it
if (!IsTraitDisabled && self.World.OrderGenerator is SellOrderGenerator) instead?

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 4, 2017

Member

Updated.

Member

MustaphaTR commented Nov 4, 2017

Updated.

@penev92 penev92 merged commit ba50fbb into OpenRA:bleed Nov 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92
Member

penev92 commented Nov 5, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:refund-text-condition branch Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment