New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /kill and /dispose chat commands #14291

Merged
merged 1 commit into from Dec 27, 2017

Conversation

Projects
None yet
7 participants
@MustaphaTR
Member

MustaphaTR commented Nov 4, 2017

I felt need for these some times, so i decided to add them. /kill kills and /dispose disposes the selected actor.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Nov 4, 2017

Contributor

OpenRA.Mods.Common/Commands/DevCommands.cs:L143: [SA1513] Statements or elements wrapped in curly brackets must be followed by a blank line.
OpenRA.Mods.Common/Commands/DevCommands.cs:L153: [SA1513] Statements or elements wrapped in curly brackets must be followed by a blank line.

Contributor

reaperrr commented Nov 4, 2017

OpenRA.Mods.Common/Commands/DevCommands.cs:L143: [SA1513] Statements or elements wrapped in curly brackets must be followed by a blank line.
OpenRA.Mods.Common/Commands/DevCommands.cs:L153: [SA1513] Statements or elements wrapped in curly brackets must be followed by a blank line.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 4, 2017

Member

Updated.

Member

MustaphaTR commented Nov 4, 2017

Updated.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Nov 11, 2017

Contributor

kill should try parsing a damagetype out from the argument and then call it's Kill(damagetype) variant if succeeded - look at devcash commands for an example.

Contributor

GraionDilach commented Nov 11, 2017

kill should try parsing a damagetype out from the argument and then call it's Kill(damagetype) variant if succeeded - look at devcash commands for an example.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 15, 2017

Member

kill should try parsing a damagetype out from the argument and then call it's Kill(damagetype) variant if succeeded - look at devcash commands for an example.

This would make the command much more useful for e.g. testing death animations. Can you please add this?

Member

pchote commented Nov 15, 2017

kill should try parsing a damagetype out from the argument and then call it's Kill(damagetype) variant if succeeded - look at devcash commands for an example.

This would make the command much more useful for e.g. testing death animations. Can you please add this?

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 22, 2017

Member

Updated. It currently only allows 1 damage type, but i'll try to update it to allow multipile when i have time.

Member

MustaphaTR commented Nov 22, 2017

Updated. It currently only allows 1 damage type, but i'll try to update it to allow multipile when i have time.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 25, 2017

Member

Updated, it now allows multipile types.

WithDeathAnimation only plays the first anim. (It'll play BulletDeath either you write /kill FireDeath BulletDeath or /kill BulletDeath FireDeath as BulletDeath is defined first under WithDeathAnimation). So you may wanna test with something like this.

Member

MustaphaTR commented Nov 25, 2017

Updated, it now allows multipile types.

WithDeathAnimation only plays the first anim. (It'll play BulletDeath either you write /kill FireDeath BulletDeath or /kill BulletDeath FireDeath as BulletDeath is defined first under WithDeathAnimation). So you may wanna test with something like this.

@Phrohdoh

Inline nits (please use var where applicable).

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 26, 2017

Member

Updated.

Member

MustaphaTR commented Dec 26, 2017

Updated.

@GraionDilach

👍

@pchote

pchote approved these changes Dec 27, 2017

@pchote pchote merged commit 5ac0625 into OpenRA:bleed Dec 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:kill-and-dispose-commands branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment