New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order deserialization when there is no indended order subject #14295

Merged
merged 1 commit into from Nov 12, 2017

Conversation

Projects
None yet
3 participants
@penev92
Member

penev92 commented Nov 5, 2017

Fixes an issue introduced in #14189. The old code relied on some ... questionable behaviour.
Basically the fix is "if there is an intended subject for the order but we can't find it, return null; if we didn't find a subject actor because the subject ID is a placeholder, carry on".

Fixes #14284.

@penev92 penev92 added this to the Next + 1 milestone Nov 5, 2017

@pchote

pchote approved these changes Nov 12, 2017

Good catch!

@pchote pchote added the PR: Needs +2 label Nov 12, 2017

@reaperrr reaperrr merged commit 8d7eb0b into OpenRA:bleed Nov 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment