New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA - Fix Fake Naval Yard's Name #14299

Merged
merged 1 commit into from Nov 12, 2017

Conversation

Projects
None yet
5 participants
@MustaphaTR
Member

MustaphaTR commented Nov 6, 2017

It was called Fake Shipyard, while actual one is called Naval Yard.

An overlook from #12469.

Would be good to add this into #14242 i guess.

@Arular101

Arular101 approved these changes Nov 9, 2017 edited

👍

I noticed that in soviet-05/soviet05-AI.lua and soviet-05/map.yaml it is still called shipyard. I'm currently investigating all campaign files, and will make in the next few days a PR fixing some errors. I'll leave it to you if you want to change it in this PR or that I do it.

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 9, 2017

Member

Funnily enough, the actor is still called syrd. What are the odds WW messed up its tooltip text and it was supposed to be called Shipyard? :D

Member

penev92 commented Nov 9, 2017

Funnily enough, the actor is still called syrd. What are the odds WW messed up its tooltip text and it was supposed to be called Shipyard? :D

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 9, 2017

Member

I think Shipyard was the name they decided first, but later changed to Naval Yard and gone lasy to fix the codename. There are other examles of this, for example Sea Scorpion's code name is HYD in RA2, which is the old unit called hydrofoil.

Member

MustaphaTR commented Nov 9, 2017

I think Shipyard was the name they decided first, but later changed to Naval Yard and gone lasy to fix the codename. There are other examles of this, for example Sea Scorpion's code name is HYD in RA2, which is the old unit called hydrofoil.

@pchote

pchote approved these changes Nov 12, 2017

@pchote pchote merged commit 3aa91a0 into OpenRA:bleed Nov 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 12, 2017

Member

https://github.com/OpenRA/OpenRA/wiki/Changelog/_compare/aaba7c0450c5e936b96558792c189741467a0524 (cherry picked to prep-1712, so adding to the "release" changelog).

Member

pchote commented Nov 12, 2017

https://github.com/OpenRA/OpenRA/wiki/Changelog/_compare/aaba7c0450c5e936b96558792c189741467a0524 (cherry picked to prep-1712, so adding to the "release" changelog).

@pchote pchote added this to the Next release milestone Nov 12, 2017

@MustaphaTR MustaphaTR deleted the MustaphaTR:fake-shipyard-name branch Nov 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment