New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Types: support for InfiltrateFor* traits #14311

Merged
merged 1 commit into from Dec 27, 2017

Conversation

Projects
None yet
4 participants
@MustaphaTR
Member

MustaphaTR commented Nov 7, 2017

This is required for RA Classic mod as there are 2 infiltrators (Spy and Thief) that do different things in same building.

For TESTCASE i buffed British Spy to give a better sonar pulse, create power outage for double the time and steal 75% of the cash instead of 50%.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 17, 2017

Member

Updated.

Member

MustaphaTR commented Nov 17, 2017

Updated.

@GraionDilach

👍

@pchote pchote dismissed their stale review Dec 27, 2017

Changes addressed.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 27, 2017

Member

Removed the testcase.

Member

MustaphaTR commented Dec 27, 2017

Removed the testcase.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 27, 2017

Member

This makes a backwards incompatible change to the mod rules (specifying Types is required for the effects to work), so this really should have an upgrade rule warning about this. But... the current UpgradeRules code doesn't cleanly support the way this warning should work (only warn once, if it encounters one of the affected traits) and so this can wait until the upgrade rule overhaul that makes it easy.

Member

pchote commented Dec 27, 2017

This makes a backwards incompatible change to the mod rules (specifying Types is required for the effects to work), so this really should have an upgrade rule warning about this. But... the current UpgradeRules code doesn't cleanly support the way this warning should work (only warn once, if it encounters one of the affected traits) and so this can wait until the upgrade rule overhaul that makes it easy.

@pchote

pchote approved these changes Dec 27, 2017

LGTM otherwise

@pchote pchote merged commit fc07391 into OpenRA:bleed Dec 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:infiltrate-for-types branch Dec 27, 2017

@pchote pchote referenced this pull request Jun 3, 2018

Merged

Add more update rules #15010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment