New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spy voices #14322

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
5 participants
@Arular101
Contributor

Arular101 commented Nov 8, 2017

The spy has several different lines in voices.yaml. However, in the infantry.yaml the move and action voices are mixed up. If the spy disguises, it uses the move voices. If the spy moves, it uses the action voices.

Action: sking1: "For King and Country!"

Move: sonway1: "On my way!"
sindeed1: "Indeed!"

@abc013

abc013 approved these changes Nov 11, 2017

Show outdated Hide outdated mods/ra/rules/infantry.yaml Outdated
@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 11, 2017

Contributor

Updated.

Nice catch!

Contributor

Arular101 commented Nov 11, 2017

Updated.

Nice catch!

@ltem

ltem approved these changes Nov 11, 2017

@pchote

pchote approved these changes Nov 12, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 15, 2017

Member

This is an easy polish win, so adding to the hotfix milestone.

Member

pchote commented Nov 15, 2017

This is an easy polish win, so adding to the hotfix milestone.

@reaperrr reaperrr merged commit fd9cd78 into OpenRA:bleed Nov 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 15, 2017

@Arular101 Arular101 deleted the Arular101:SpyVoice branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment