New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign file changes and cleanup #14326

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
3 participants
@Arular101
Contributor

Arular101 commented Nov 10, 2017

I wanted to unify the campaign units with the skirmish/multiplayer units as much as possible. I also found some redundant code. For some reason there are a lot of actors with 99% HP. This PR changes it back to 100% HP. Last but not least, the enemy has now an ore truck in Soviet-02b.

Allies-01
Map.yaml:
Removed 99% HP for kennel. Don’t know why this is.
Removed ore refinery FreeActor: False. This will now give an ore truck.
Removed Harvester: harv. The ore truck is now given by the ore refinery.

Allies01.lua:
Removed Harvester.FindResources(). This is not needed anymore.

Weapons.yaml:
Removed custom rules for M60mg. This rule made the ranger very strong vs heavy armor. The ranger is strong enough to kill all the infantry. There is no need for this buff. The cruisers already destroy the base. If desired, the ore truck could be destroyed in the meantime with all the infantry and rangers available. This change unifies the campaign and skirmish/multiplayer experience.

Allies-02
Map.yaml:
Removed 99% HP for kennel. Don’t know why this is.
Removed 56% HP for grenadier (close at the starting location, next to the barrels). I see no reason why this unit should stay wounded. This unit will die if the player shoots at the barrels anyway.
Removed 50% HP for ore truck. I see no reason why this unit should stay damaged. The player can train rocket soldiers to destroy the ore truck quickly. On the difficulty level real tuff guy, the player cannot build a base, making it take a little bit longer to destroy the ore truck. I managed to complete this mission without problems. After killing a 100% HP ore truck, I totally felt like a real tuff guy! :P

Removed weapons.yaml:
Here again, no need for a custom rule for the ranger. Like said above, I completed this mission at real tuff guy difficulty level without any trouble.

Rules.yaml:
Removed HARV: Buildable: Prerequisites: weap. This is not needed.

Allies-03b
Rules.yaml:
Removed FTUR: DetectCloaked: Range: 0.
Removed DOME: DetectCloaked: Range: 0. These are not needed.

Weapons.yaml:
Removed FireballLauncher: Projectile: High: True. This is not needed.

Allies-05a
Rules.yaml
Removed FTUR: DetectCloaked: Range: 0.
Removed TSLA: DetectCloaked: Range: 0.
Removed SAM: DetectCloaked: Range: 0. These are not needed.
Renamed MISS: Armament: Weapon: MissionColt -> PrisonColt. This is only used for the gunshot sounds in the prison.

Weapons.yaml:
Renamed MissionColt -> PrisonColt
Changed ReloadDelay: 6 -> ReloadDelay: 5. This brings it in line with the colt45 ReloadDelay, which Tanya uses.
Removed Range: 7c0, Spread: 42, Damage: 50, Versus: Wood: 10, DamageTypes: Prone50Percent, TriggerProne, BulletDeath. These things aren’t needed. We only need the gunshot sounds.

Allies-06a
Removed weapons.yaml:
Here again, no need for a custom rule for the ranger. There are stronger units available.

Soviet-02a
Map.yaml:
Removed 99% HP for fact.
Removed 98% HP for weap.
Removed 99% HP for powr.
Removed 99% HP for fcom.
Removed 99% HP for dome.
Removed 99% HP for proc. I don’t know why these are.

Rules.yaml:
Removed custom rules for attack dogs. The attack dog got a HP buff in the last release, bringing it close to these custom rules.

Soviet-02b
Map.yaml:
Removed ore refinery FreeActor: False. This will now give an ore truck. The enemy did not had an ore truck in this mission.
Removed 55% HP for jeep.
Removed 59% HP for jeep.
Removed 56% HP for gun.
Removed 53% HP for gun. I see no reason why these units should stay damaged. These units could still be easily destroyed by the Yaks.

Removed weapons.yaml:
Removed the custom rules for the barrels. The explosion damage of the barrels is now a bit lesser. The mission still feels the same.

Rules.yaml:
Removed FCOM: RepairableBuilding: It is not possible to repair this building like in the A-version of this mission (and skirmish/multiplayer).
Removed custom rules for attack dogs. The attack dog got a HP buff in the last release, bringing it close to these custom rules.
Removed BARL and BRL3 custom rules. See above.

Soviet-03
Map.yaml:
Removed 99% HP for Actor120: v07.
Removed 56% BaseBuilding6: miss. There is no reason why the prison is damaged. It will blow up anyway.
Removed 99% HP for SpyHideout1: v01.
Removed 99% HP for SpyHideout1: v01.
Removed 99% HP for SpyHideout1: v01.

Removed weapons.yaml:
Removed the custom rules for the barrels. The explosion damage of the barrels is now a bit lesser. The mission still feels the same.

Rules.yaml:
Removed NoAutoTarget from TechBuilding. This is not needed.
Removed BARL and BRL3 custom rules. See above.

Soviet-04a
Mas.yaml:
Removed 99% HP for Actor144: 2tnk.
Removed 99% HP for Actor145: 2tnk.
Removed 99% HP for Tank3: 3tnk.

Soviet-05a
Map.yaml:
Renamed Shipyard to Navalyard.

Rules.yaml:
Removed NoAutoTarget from radar dome. This is not needed anymore since the current release doesn't target buildings.

Soviet05a-AI.lua:
Renamed Shipyard to Navalyard.

Soviet-06a
Map.yaml:
Removed 99% HP for Actor186: 3tnk.
Removed 99% HP for Actor187: 3tnk.

Rules.yaml:
Removed custom rules for attack dogs. The attack dog got a HP buff in the last release, bringing it close to these custom rules.

Soviet-06b
Map.yaml:
Removed 99% HP for Actor110: 3tnk.
Removed 99% HP for Actor111: 3tnk.

Rules.yaml:
Removed custom rules for attack dogs. The attack dog got a HP buff in the last release, bringing it close to these custom rules.

Soviet-07
Weapons.yaml:
Changed the M1CarbineInterior to M1Carbine, with only one necessary modified rule. (The rest of the rules are the same.)
Changed the FireballLauncherInterior to FireballLauncher, with only one necessary modified rule. (The rest of the rules are the same.)
Changed FireballLauncher range from 3c0 to 3c128. The flame tower on the right of the map could not reach the infantry passing by to the right of it.

Removed the custom rules for the barrels. The explosion damage of the barrels are now a bit lesser. The mission still feels the same, only 3 enemy infantry units barely survives in the beginning, but they are easily killed. I could still beat the mission on hard difficulty level within 4 minutes.

Rules.yaml:
Removed BARL and BRL3 custom rules. See above.
Removed custom weapon E1
Removed custom weapon FTUR

Campaign file changes and cleanup
Remove NoAutoTarget
@pchote

pchote approved these changes Nov 15, 2017

The changes described in the PR description all seem sensible. Note that I haven't tested the modified missions.

@pchote pchote added the PR: Needs +2 label Nov 15, 2017

@reaperrr

Haven't tested the missions (would be too time-consuming), but the changes all look sensible 👍

@reaperrr reaperrr merged commit 8bec765 into OpenRA:bleed Nov 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 15, 2017

@Arular101 Arular101 deleted the Arular101:CampaignFileChanges branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment