New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kill Bounties checkbox to RA lobby options #14363

Merged
merged 4 commits into from Dec 21, 2017

Conversation

Projects
None yet
5 participants
@pchote
Member

pchote commented Nov 15, 2017

This reimplements #14245 in a more generic way. Depends on #14359.

@pchote pchote referenced this pull request Nov 15, 2017

Closed

Implement bounty checkbox #14245

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Nov 15, 2017

Contributor

Some RA maps don't pass Travis with this.

Edit: though maybe that's caused by the campaign cleanups? Though that would beg the question why that PR passed the test.

Contributor

reaperrr commented Nov 15, 2017

Some RA maps don't pass Travis with this.

Edit: though maybe that's caused by the campaign cleanups? Though that would beg the question why that PR passed the test.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 15, 2017

Member

Fixed (hopefully). The issue was that I added a suffix to the inherited GivesBounty, which broke the maps that tried to remove it.

Member

pchote commented Nov 15, 2017

Fixed (hopefully). The issue was that I added a suffix to the inherited GivesBounty, which broke the maps that tried to remove it.

@cjshmyr cjshmyr referenced this pull request Nov 24, 2017

Open

TODO List #1

40 of 77 tasks complete

@pchote pchote added this to the Next release milestone Dec 12, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 12, 2017

Member

Updated and ready to review. I chose to leave the bounty option enabled on the coop missions, Fort Lonestar, and Training Camp.

Member

pchote commented Dec 12, 2017

Updated and ready to review. I chose to leave the bounty option enabled on the coop missions, Fort Lonestar, and Training Camp.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 20, 2017

Member

Needs Rebase.

Member

MustaphaTR commented Dec 20, 2017

Needs Rebase.

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Dec 20, 2017

Contributor

👍 Works as advertised. Can't say much about the code, but I did check the yaml files, which looks good to me.

I'm not sure if this is because it needs a rebase, but the Debug Menu checkbox is now the first checkbox.

Contributor

Arular101 commented Dec 20, 2017

👍 Works as advertised. Can't say much about the code, but I did check the yaml files, which looks good to me.

I'm not sure if this is because it needs a rebase, but the Debug Menu checkbox is now the first checkbox.

@pchote pchote removed the PR: Rebase me! label Dec 21, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 21, 2017

Member

Rebased.

Member

pchote commented Dec 21, 2017

Rebased.

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Dec 21, 2017

Contributor

👍

Contributor

Arular101 commented Dec 21, 2017

👍

namespace OpenRA.Mods.Common.Traits
{
[Desc("Enables defined prerequisites at game start for all players if the checkbox is enabled.")]

This comment has been minimized.

@reaperrr

reaperrr Dec 21, 2017

Contributor

Nice, we could use this later to toggle Firestorm stuff in TS.

@reaperrr

reaperrr Dec 21, 2017

Contributor

Nice, we could use this later to toggle Firestorm stuff in TS.

@reaperrr reaperrr merged commit d24d80f into OpenRA:bleed Dec 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:ra-disable-bounty branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment