New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip fixes #14371

Merged
merged 2 commits into from Nov 19, 2017

Conversation

Projects
None yet
4 participants
@Arular101
Contributor

Arular101 commented Nov 17, 2017

Added to fake structures with a build limit of one that only one can be build.
Changed the transport helicopter husk names to Chinook. (Transport helicopter was changed to Chinook last release.)
Changed Mig to MiG. MiG is a abbreviation of Mikoyan and Gurevich, see Wikipedia.
Rearranged the support powers of the airfield to mirror the arrangement of the support powers in the upper left corner.
Removed "Can detect cloaked units." from SAM and AA Gun. (This feature was removed in the last release.)
Clarified some descriptions, please see the "Files changed".

I also wanted to add the description of the parabombs support power in the airfield for Ukraine only. But, I don't know if that's worth it.

I have two related questions:

  1. Some units with no capabilities to shoot at aircraft has the description "Weak vs Aircraft". Also, the SAM and AA Gun has the description "Weak vs Ground units". Is this desired?
    2

  2. Punctuation is not consistent. Is there any rule about how to do it?
    1

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Nov 17, 2017

Contributor

To 1., yes, iirc that's intentional.

Punctuation is not consistent. Is there any rule about how to do it?

Not really, I think. Though by the look of things, I'd go for "Descriptive sentence should always end with full stop", "Strong/Weak vs. should always end without full stop".
It's up to you whether you add another commit here or file another PR later.

Contributor

reaperrr commented Nov 17, 2017

To 1., yes, iirc that's intentional.

Punctuation is not consistent. Is there any rule about how to do it?

Not really, I think. Though by the look of things, I'd go for "Descriptive sentence should always end with full stop", "Strong/Weak vs. should always end without full stop".
It's up to you whether you add another commit here or file another PR later.

@MustaphaTR

Current changes look good to me.

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 17, 2017

Contributor

Updated.

In the second commit I moved “Maximum 1 can be trained.” up to the other sentences without the two spaces, see:
3

There was luckily only one instance with wrong punctuation.

Capitalized Tesla because it is a name.

Radar dome was the only structure with two spaces in front of the “Requires power to operate.”

I also wanted to remove the name of the unit in the description. It was only in three cases, these are: Light tank, Demolition truck and Chrono tank.

Added info for the Ranger that it can carry a passenger. Mammoth tank for crushing concrete walls.

The rest are minor adjustments. If something is not desired, or could be changed in a better way, please feel free to say it and I will gladly change it.

I’ll squash the commits after the review.

Contributor

Arular101 commented Nov 17, 2017

Updated.

In the second commit I moved “Maximum 1 can be trained.” up to the other sentences without the two spaces, see:
3

There was luckily only one instance with wrong punctuation.

Capitalized Tesla because it is a name.

Radar dome was the only structure with two spaces in front of the “Requires power to operate.”

I also wanted to remove the name of the unit in the description. It was only in three cases, these are: Light tank, Demolition truck and Chrono tank.

Added info for the Ranger that it can carry a passenger. Mammoth tank for crushing concrete walls.

The rest are minor adjustments. If something is not desired, or could be changed in a better way, please feel free to say it and I will gladly change it.

I’ll squash the commits after the review.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 18, 2017

Member

Can you add Can detect cloaked units. to Tanya too?

Member

MustaphaTR commented Nov 18, 2017

Can you add Can detect cloaked units. to Tanya too?

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 18, 2017

Contributor

Good catch, will do. I just added that for the Mammoth tank.

Contributor

Arular101 commented Nov 18, 2017

Good catch, will do. I just added that for the Mammoth tank.

Arular101 added some commits Nov 17, 2017

@Arular101

This comment has been minimized.

Show comment
Hide comment
@Arular101

Arular101 Nov 18, 2017

Contributor

Updated with Tanya can detect cloak.

Contributor

Arular101 commented Nov 18, 2017

Updated with Tanya can detect cloak.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 19, 2017

Member

My 👍 still stands.

Member

MustaphaTR commented Nov 19, 2017

My 👍 still stands.

@reaperrr reaperrr merged commit 586dd65 into OpenRA:bleed Nov 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 19, 2017

@Arular101 Arular101 deleted the Arular101:tooltipfix branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment