New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocations needed by ReplayConnection. #14374

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Nov 17, 2017

Reduce memory required to hold replays as part of efforts to tackle #12494.

Reduce allocations needed by ReplayConnection.
Packets from each chunk are now saved directly in an array, removing the overhead of a list. Additionally, a list is reused as a buffer for decoding packets into, preventing a new buffer from needing to be allocated for each chunk.
@pchote

pchote approved these changes Nov 19, 2017

@pchote pchote merged commit 713cdae into OpenRA:bleed Nov 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RoosterDragon RoosterDragon deleted the RoosterDragon:replay-alloc-trim branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment