New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GC more during loading. #14375

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Nov 17, 2017

This helps reduce the peak GC size by trimming temporary loading garbage a bit more often, rather than just doing it at the end of loading.

Helps reduce our peak virtual memory usage be reducing the spike the occurs during loading. Should help with #12494 for when loading pushes you over the edge but after loading you would free enough memory to have it be otherwise playable.

Run GC more during loading.
This helps reduce the peak GC size by trimming temporary loading garbage a bit more often, rather than just doing it at the end of loading.
@pchote

pchote approved these changes Nov 19, 2017

@pchote pchote merged commit 471d7ae into OpenRA:bleed Nov 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RoosterDragon RoosterDragon deleted the RoosterDragon:loading-gc branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment