New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Add Harkonnen 5 #14388

Merged
merged 2 commits into from Nov 26, 2017

Conversation

Projects
None yet
3 participants
@MustaphaTR
Member

MustaphaTR commented Nov 19, 2017

Something is off with Ordos' Outpost/Power level and i'm not sure what. Outpost looks disabled. I spammed Wind Traps on editor to test but it didn't change anything. Power level also should be OK according to my calculations.

This also adds Modified Outpost tooltip to Ordos 4, which that Outpost were in original game. It doesn't really matter for that mission infact, as you weren't able to see it (it would show Enemy Structure) in original. It is in OpenRA right now tho.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Nov 19, 2017

Contributor

Something is off with Ordos' Outpost/Power level and i'm not sure what. Outpost looks disabled. I spammed Wind Traps on editor to test but it didn't change anything. Power level also should be OK according to my calculations.

Might be a regression from my power traits refactor, I'll check when I get around to reviewing this.

Contributor

reaperrr commented Nov 19, 2017

Something is off with Ordos' Outpost/Power level and i'm not sure what. Outpost looks disabled. I spammed Wind Traps on editor to test but it didn't change anything. Power level also should be OK according to my calculations.

Might be a regression from my power traits refactor, I'll check when I get around to reviewing this.

@reaperrr reaperrr referenced this pull request Nov 19, 2017

Closed

Get the remaining Harkonnen missions into the playtest #14392

5 of 5 tasks complete
@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 20, 2017

Member

I made the player Ordos Main Base to test, Outpost looks disabled. it doesn't provide radar either. Power level is OK.

Member

MustaphaTR commented Nov 20, 2017

I made the player Ordos Main Base to test, Outpost looks disabled. it doesn't provide radar either. Power level is OK.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Nov 24, 2017

Contributor

Plays like the original, even better, Corrino is attacking what didn't happen for some reason in the original. Also didn't find any issues in the code.

Two things I noticed:

  1. It wasn't possible to build Siege Tanks for the Harkonnen-player.
image
  1. If you wall of the Modified Outpost, the enemy units won't attack it anymore. I'm quite sure this happens due to the pathfinding but I don't see it as a problem.

So as soon as a solution is found for the Power level and the Siege Tank, I will approve this PR.

Contributor

ltem commented Nov 24, 2017

Plays like the original, even better, Corrino is attacking what didn't happen for some reason in the original. Also didn't find any issues in the code.

Two things I noticed:

  1. It wasn't possible to build Siege Tanks for the Harkonnen-player.
image
  1. If you wall of the Modified Outpost, the enemy units won't attack it anymore. I'm quite sure this happens due to the pathfinding but I don't see it as a problem.

So as soon as a solution is found for the Power level and the Siege Tank, I will approve this PR.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Nov 25, 2017

Member

Updated. Disabled the Siege Tank. #14416 is gonna fix the power. It is not related to this PR.

Member

MustaphaTR commented Nov 25, 2017

Updated. Disabled the Siege Tank. #14416 is gonna fix the power. It is not related to this PR.

@ltem

ltem approved these changes Nov 25, 2017

I rebased #14416 onto this pr and it fixed the power level issue, so 👍.

@reaperrr reaperrr merged commit 2043576 into OpenRA:bleed Nov 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 26, 2017

@penev92 penev92 referenced this pull request Nov 27, 2017

Open

Add Dune 2000 campaign #9287

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-harkonnen-5 branch Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment