Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for V2 Rocket Launcher facings #14393
I’ve found a solution for the V2 rocket launcher shaking. The V2 rocket launcher has 32 facings for when it is loaded with a rocket and 32 facings without a rocket. Additional, there are only 8 facings for when the rocket is raised and only 8 facings when the rocket is launched with that thing that holds the rocket still raised. Now, I’ve inspected the original game and that thing that raises the rocket is not used there. (I always thought that I missed that detail somehow in the originals.)
So, in order to fix this problem, I removed the aim and empty-aim in sequences/vehicles.yaml. Now the V2 rocket launcher doesn’t shake anymore. There is only a small problem with that.
If the V2 faces one direction (let’s say to the east) with still a rocket on it. And it shoot its rocket to the east, the image of the V2 doesn’t change to an image of a V2 without a rocket.
The solution for that was to reuse the empty-aim trait, but this time pointing at the 32 facings of a V2 without a rocket. Now the V2 rocket launcher works perfectly!
First of all, I agree with the general fix; the idea behind the aim sequences wasn't bad, but with only 8 facings, the glitching always hurt more than the raised rocket/ramp added. This should've been either upgraded to a full 32-facing sprite, or removed again long ago.
This would be the best solution, yes.
But regardless of which approach, the "aim" and "aim-empty" sequences should go away now instead of becoming duplicates, WithAttackAnimation can use idle(-empty) as well.
@Arular101 If you need help with setting up the AmmoPool approach, notify us (or come to the IRC channel).
I was a bit too excited when I fixed that bug, that I completely missed the aim and empty-aim sequences were called in the rules/vehicles.yaml. I also want to fix this properly.
I did a little investigation of how to do it with the things MustaphaTR mentioned. I could implement the
@Arular101 That shouldn't be necessary. You just need one
referenced this pull request
Nov 25, 2017
@reaperrr, @pchote, sorry to bother you guys again, but currently at bleed the V2 rocket launcher is invisible and unselectable.
Only way I was able to get it work was with this:
How should I proceed?