Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS harvester and MammothMk2 not rendering #14398

Merged
merged 2 commits into from Nov 29, 2017

Conversation

reaperrr
Copy link
Contributor

Fixes #14395.

@penev92
Copy link
Member

penev92 commented Nov 22, 2017

This needs to go into the first playtest since it fixes a major regression that would otherwise be present in that playtest.

@penev92 penev92 added this to the Next release milestone Nov 22, 2017
@reaperrr
Copy link
Contributor Author

it doesn't affect the shipping mods so strictly speaking it's not a hard requirement, but I agree we shouldn't ship a release with this bug.

@Smittytron
Copy link
Member

First time I've loaded up TS. Jumpjet Inf, Wolverine, Titan, and Juggernaut all don't render.

@reaperrr
Copy link
Contributor Author

reaperrr commented Nov 22, 2017

These are mostly yaml issues, I'll add a Ruleset loading check to avoid these in the future.

With one two exceptions: I don't see why the Jumpjet and Juggernaut don't render, only using CustomRenderSize instead of AutoRenderSize worked for me. The shp bounds themselves can't be the problem (it worked before when AutoSelectionSize was used for render bounds, afterall), so the bug is likely definitely related to handling multiple sprite/infantry bodies on one actor, and RenderSprites.AutoRenderSize.
Maybe some implicit trait order dependency, too. In any case, I can't pin it down so far.

Pinging @pchote for ideas.

@pchote
Copy link
Member

pchote commented Nov 23, 2017

Note that I don't get the ping when that is edited in after the first submission 😉

@reaperrr
Copy link
Contributor Author

The problems with sprite bounds are more complicated, I'll file a separate PR for that so we can get this PR out of the way more quickly.

@penev92 penev92 merged commit c48ddbd into OpenRA:bleed Nov 29, 2017
@penev92
Copy link
Member

penev92 commented Nov 29, 2017

Changelog

@reaperrr reaperrr deleted the fix-voxel-bounds branch February 22, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants