New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Add Campaign Tooltip #14403

Merged
merged 1 commit into from Dec 30, 2017

Conversation

Projects
None yet
4 participants
@MustaphaTR
Member

MustaphaTR commented Nov 22, 2017

Depends on #14404.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 28, 2017

Member

Dependency has been merged, so can now be rebased to help with testing.

Member

pchote commented Dec 28, 2017

Dependency has been merged, so can now be rebased to help with testing.

@pchote pchote added this to the Next release milestone Dec 28, 2017

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 28, 2017

Member

Rebased.

Member

MustaphaTR commented Dec 28, 2017

Rebased.

@pchote pchote added the PR: Needs +2 label Dec 29, 2017

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 30, 2017

Member

Updated.

Member

MustaphaTR commented Dec 30, 2017

Updated.

@abcdefg30

👎 I really oppose the idea to hide the owner row for good. It just hides the "hacks" going on behind the veil. Ideally we should rather fix that 'properly'. However, I see that this is not going to happen (soon) and considering that several missions were already merged with that, I fear I need to take this in.

@abcdefg30 abcdefg30 merged commit 69e9b94 into OpenRA:bleed Dec 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-campaign-tooltip branch Dec 30, 2017

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment