New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TD cliff tiles 29-31 #14413

Merged
merged 1 commit into from Nov 26, 2017

Conversation

Projects
None yet
3 participants
@Smittytron
Contributor

Smittytron commented Nov 24, 2017

Closes #14412

Desert tileset was correct.

@ltem

ltem approved these changes Nov 25, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Nov 26, 2017

Contributor

For the record: I remember I once filed a PR to fix this too, but back then it was rejected mainly because "some maps might be designed with these passable cells in mind".
However, I still think we shouldn't reject obvious bugfixes with that kind of reason, and if we do stumble over any map designed around this wrong passability we should either fix the map or throw it out.
Also, the above is obviously not the case for any of the singleplayer imported from the original game either, so 👍

Contributor

reaperrr commented Nov 26, 2017

For the record: I remember I once filed a PR to fix this too, but back then it was rejected mainly because "some maps might be designed with these passable cells in mind".
However, I still think we shouldn't reject obvious bugfixes with that kind of reason, and if we do stumble over any map designed around this wrong passability we should either fix the map or throw it out.
Also, the above is obviously not the case for any of the singleplayer imported from the original game either, so 👍

@reaperrr reaperrr merged commit d5622ae into OpenRA:bleed Nov 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Nov 26, 2017

@Smittytron Smittytron deleted the Smittytron:TD-cliffs branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment