New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty children when aggregating EventBounds. #14418

Merged
merged 1 commit into from Nov 27, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Nov 25, 2017

This PR fixes cases where the parent widget's EventBounds are expanded to include the origin, which breaks tooltips and other mouseover events unless all parent widgets are ClickThrough or ignore events. This hasn't been an issue for our default mods, but breaks at least one third party mod that uses custom UI (Medieval Warfare).

Testcase:

  1. Clone and compile https://github.com/CombinE88/Medieval-Warfare
  2. Start a skirmish and notice that the world tooltips (unit mouseover, "Unrevealed Terrain", etc) do not work at the start of the game.
  3. Update mod.config to set ENGINE_VERSION="fix-eventbound-aggregation-testcase" and AUTOMATIC_ENGINE_SOURCE="https://github.com/pchote/OpenRA/archive/${ENGINE_VERSION}.zip" and then recompile.
  4. Start a skirmish and notice that world tooltips now work correctly.

@pchote pchote added this to the Next release milestone Nov 25, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 26, 2017

Member

Fixed.

Member

pchote commented Nov 26, 2017

Fixed.

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 27, 2017

Member

Seems to get the job done 👍

P.S.: If anyone wants to test, use this specific version.

Member

penev92 commented Nov 27, 2017

Seems to get the job done 👍

P.S.: If anyone wants to test, use this specific version.

@penev92 penev92 merged commit 4994716 into OpenRA:bleed Nov 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92
Member

penev92 commented Nov 27, 2017

@pchote pchote deleted the pchote:fix-eventbound-aggregation branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment