New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PredictedStance when changing stance from Lua. #14421

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Nov 25, 2017

Fixes #14340.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Nov 25, 2017

Member

Testcase:

--- a/mods/cnc/maps/gdi01/gdi01.lua
+++ b/mods/cnc/maps/gdi01/gdi01.lua
@@ -38,6 +38,10 @@ ReinforceWithLandingCraft = function(units, transportStart, transportUnload, ral
 
                        if rallypoint ~= nil then
                                a.Move(rallypoint)
+                               print(a.Type)
+                               print(a.Stance)
+                               a.Stance = "AttackAnything"
+                               print(a.Stance)
                        end
                end)
        end)

Before fix: UI does not change to AttackAnything stance. After fix: it does.

Member

pchote commented Nov 25, 2017

Testcase:

--- a/mods/cnc/maps/gdi01/gdi01.lua
+++ b/mods/cnc/maps/gdi01/gdi01.lua
@@ -38,6 +38,10 @@ ReinforceWithLandingCraft = function(units, transportStart, transportUnload, ral
 
                        if rallypoint ~= nil then
                                a.Move(rallypoint)
+                               print(a.Type)
+                               print(a.Stance)
+                               a.Stance = "AttackAnything"
+                               print(a.Stance)
                        end
                end)
        end)

Before fix: UI does not change to AttackAnything stance. After fix: it does.

@pchote pchote added this to the Next release milestone Nov 25, 2017

@abcdefg30 abcdefg30 merged commit cb670d8 into OpenRA:bleed Dec 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 8, 2017

@pchote pchote deleted the pchote:fix-lua-stance branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment