New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE when ProvidesPrerequisite is defined on the player actor. #14428

Merged
merged 1 commit into from Nov 26, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Nov 26, 2017

Fix for #14426.

Testcase: Move the ProvidesPrerequisite definitions added in #14426 from player_prerequisite to Player in the map rules. Before: crashes on map start. After: doesn't crash.

@pchote pchote requested a review from MustaphaTR Nov 26, 2017

@pchote pchote referenced this pull request Nov 26, 2017

Merged

D2K - Add Harkonnen 7 #14426

@MustaphaTR

👍 Testcase works.

@reaperrr reaperrr merged commit 8fea476 into OpenRA:bleed Nov 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:fix-player-providesprerequisite branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment