New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Add Harkonnen 9a #14429

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
6 participants
@MustaphaTR
Member

MustaphaTR commented Nov 26, 2017

No description provided.

@reaperrr reaperrr referenced this pull request Nov 26, 2017

Closed

Get the remaining Harkonnen missions into the playtest #14392

5 of 5 tasks complete

@penev92 penev92 referenced this pull request Nov 27, 2017

Open

Add Dune 2000 campaign #9287

@abc013

Well done! I also encountered the same bug as in my review here.

Show outdated Hide outdated mods/d2k/maps/harkonnen-09a/harkonnen09a.lua Outdated
Utils.Do(atreides_main.GetGroundAttackers(), IdleHunt)
end)
Trigger.OnAllKilledOrCaptured(AtreidesSmall1Base, function()

This comment has been minimized.

@abc013

abc013 Dec 6, 2017

Contributor

Same as above and so on...

@abc013

abc013 Dec 6, 2017

Contributor

Same as above and so on...

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 6, 2017

Member

I also encountered the same bug as in my review here.

This is probably related to global-lua. I'm not sure how exactly to solve tbh.

Member

MustaphaTR commented Dec 6, 2017

I also encountered the same bug as in my review here.

This is probably related to global-lua. I'm not sure how exactly to solve tbh.

@abc013

abc013 approved these changes Dec 6, 2017

Imo 👍

@pchote pchote added this to the Next release milestone Dec 9, 2017

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Dec 20, 2017

Contributor

Nice. Again it took me quite some time to finish the original mission. The only difference I noticed (except the balance) is that the Atreides (Main Base) attacks in regular intervals with a group of six Fremen (quite possible the AI waits for 3 Fremenpower cooldowns and sends them afterwards). I don't know how well the AI can handle this, so it is more a note than a request.

Also it seems that the Corrino won't get their reinforcments or at least I couldn't spot them arriving. I couldn't find the reason for it, could you check if I'm wrong? After this is cleared I'm gonna 👍 this PR.

Contributor

ltem commented Dec 20, 2017

Nice. Again it took me quite some time to finish the original mission. The only difference I noticed (except the balance) is that the Atreides (Main Base) attacks in regular intervals with a group of six Fremen (quite possible the AI waits for 3 Fremenpower cooldowns and sends them afterwards). I don't know how well the AI can handle this, so it is more a note than a request.

Also it seems that the Corrino won't get their reinforcments or at least I couldn't spot them arriving. I couldn't find the reason for it, could you check if I'm wrong? After this is cleared I'm gonna 👍 this PR.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 20, 2017

Member

Atreides (Main Base) attacks in regular intervals with a group of six Fremen (quite possible the AI waits for 3 Fremenpower cooldowns and sends them afterwards). I don't know how well the AI can handle this, so it is more a note than a request.

I don't think SpawnActorPower has a lua way to trigger itself, but i think i can just use Produce to replicate that.

Member

MustaphaTR commented Dec 20, 2017

Atreides (Main Base) attacks in regular intervals with a group of six Fremen (quite possible the AI waits for 3 Fremenpower cooldowns and sends them afterwards). I don't know how well the AI can handle this, so it is more a note than a request.

I don't think SpawnActorPower has a lua way to trigger itself, but i think i can just use Produce to replicate that.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 20, 2017

Member

Updated, AI now builds fremen.

Member

MustaphaTR commented Dec 20, 2017

Updated, AI now builds fremen.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 21, 2017

Contributor

Needs rebase.

Contributor

reaperrr commented Dec 21, 2017

Needs rebase.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 22, 2017

Member

Rebased.

Member

MustaphaTR commented Dec 22, 2017

Rebased.

@ltem ltem removed the PR: Rebase me! label Dec 22, 2017

@ltem

ltem approved these changes Dec 22, 2017

@ltem ltem merged commit 27cc487 into OpenRA:bleed Dec 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-harkonnen-9a branch Dec 22, 2017

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem
Contributor

ltem commented Dec 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment