New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K: Fix refinery smoke anim, hi-tec factory offset and tile 401 terrain type #14430

Merged
merged 3 commits into from Dec 8, 2017

Conversation

Projects
None yet
5 participants
@reaperrr
Contributor

reaperrr commented Nov 26, 2017

The refinery overlay played too slowly and was positioned a few pixels too far to the left compared to the original.

Tile 401 is "infantry-only rocks" on rock terrain and should therefore be "Rough" terrain, yet had "Sand"(!) on bleed. This affected Harkonnen mission 5 for example (north-east of starting position).

Fixes are simple and obvious enough to make this a playtest blocker.

@reaperrr reaperrr added this to the Next release milestone Nov 26, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Nov 26, 2017

Contributor

Pinging @ltem and @MustaphaTR for review.

Contributor

reaperrr commented Nov 26, 2017

Pinging @ltem and @MustaphaTR for review.

@MustaphaTR

Looks good to me.

@ltem

ltem approved these changes Nov 27, 2017 edited

All good. 👍 from me.


Maybe you could add this as well or I would do it in an other PR. I noticed while comparing with the gruntmods that our Research Center offset is by 4 pixels too low (not sure what that means in x,y,z offset).

image image
Gruntmods OpenRA

(The four small red dots symbol the offset)

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 1, 2017

Contributor

Updated, fixed factory:
hitec-facto

I also made sure I fixed all 3 and that the targetable positions are still well enough on the sprite.

Contributor

reaperrr commented Dec 1, 2017

Updated, fixed factory:
hitec-facto

I also made sure I fixed all 3 and that the targetable positions are still well enough on the sprite.

@reaperrr reaperrr changed the title from D2K: Tweak refinery smoke overlay and fix tile 401 terrain type to D2K: Fix refinery smoke anim, hi-tec factory offset and tile 401 terrain type Dec 1, 2017

@ltem

ltem approved these changes Dec 2, 2017

@penev92

penev92 approved these changes Dec 8, 2017

I count 2 valid reviews.

@penev92 penev92 merged commit 1a20dd1 into OpenRA:bleed Dec 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 8, 2017

@reaperrr reaperrr deleted the reaperrr:d2k-polishing1 branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment