Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rework mod launchers to address issues with icons on Windows #14435
Until now the mod-specific launchers (with a specific name and icon) launched the mod-agnostic
This changes the launchers to run the game loop directly, so instead of the launcher launching
Unfortunately not straight-forward to test on Windows, and apparently creating the launchers doesn't happen on Windows, so will need someone who can create those to provide reviewers with samples.
Looks good as a first cut on the feature.
Link to test build
I can confirm that this fixes pinning to taskbar, and that the icons work as expected. The crash dialog itself does not work, however.
A few minor code nits:
Updated test build: https://www.dropbox.com/s/cbgp6kk9nqmheo8/OpenRA-packagetest-20171129.exe?dl=0