New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OccupiedCells and TargetableCells must return arrays, not just enumerables. #14437

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Nov 27, 2017

This allows callers to efficiently enumerate these returned collections without the allocation and overhead imposed by the IEnumerable interface. All implementations were already returning arrays, so this only required a signature change.

OccupiedCells and TargetableCells must return arrays, not just enumer…
…ables.

This allows callers to efficiently enumerate these returned collections without the allocation and overhead imposed by the IEnumerable interface. All implementations were already returning arrays, so this only required a signature change.
@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Dec 7, 2017

Member

Seems legit 👍

Member

penev92 commented Dec 7, 2017

Seems legit 👍

@penev92 penev92 merged commit 62ab6ae into OpenRA:bleed Dec 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92
Member

penev92 commented Dec 7, 2017

@RoosterDragon RoosterDragon deleted the RoosterDragon:occupied-targeted-cells-arrays branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment