New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse buffers when loading Xcc databases. #14441

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Nov 27, 2017

We can reuse the list as a buffer when reading strings to avoid throwaway allocations, which will reduce GC pressure during loading.

Reuse buffers when loading Xcc databases.
We can reuse the list as a buffer when reading strings to avoid throwaway allocations, which will reduce GC pressure during loading.
@penev92

Sounds reasonable 👍 .

@penev92 penev92 merged commit 6a97502 into OpenRA:bleed Nov 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92
Member

penev92 commented Nov 30, 2017

@RoosterDragon RoosterDragon deleted the RoosterDragon:xcc-reuse-buffer branch Dec 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment