New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory required in MovementClassDomainIndex #14442

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Nov 27, 2017

The number of distinct domains on a map is often dozens, or at most hundreds. We can use a ushort to represent this easily, and reduce the size of the backing storage required to track domain indicies over the whole map.

Helps with #12494 by reducing overall memory required.

Reduce memory required in MovementClassDomainIndex
The number of distinct domains on a map is often dozens, or at most hundreds. We can use a ushort to represent this easily, and reduce the size of the backing storage required to track domain indicies over the whole map.

@pchote pchote added this to the Next release milestone Dec 9, 2017

@pchote

pchote approved these changes Dec 10, 2017

@pchote pchote added the PR: Needs +2 label Dec 10, 2017

@abcdefg30 abcdefg30 merged commit ec84b61 into OpenRA:bleed Dec 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 11, 2017

@RoosterDragon RoosterDragon deleted the RoosterDragon:domain-mem-shrink branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment