New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more D2k asset installers #14446

Merged
merged 5 commits into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@penev92
Member

penev92 commented Nov 28, 2017

It recently turned out that there were numerous distributions of D2k floating around with minimal differences (Important difference: the package SETUP.Z has different contents! ... from what I've seen the different distributions contain packaging fixes). Our assets installers are quite picky, though, and the two we have are not enough.
I have added THREE new asset installers based on #14289, #14319 and my own version of the game.

I was very thorough in checking that all 5 installers produce the exact same output when installing from each and every one of them, but it would be nice if someone on Linux/Mac can verify, as we apparently have special installers for those.

Testing this is going to be a PITA if you intend to install. Personally I got the SETUP.Z files from #14289 and #14319 and ended up having to create an ISO based on my CD and modify it with those in order to test.

@penev92 penev92 added this to the Next release milestone Nov 28, 2017

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 28, 2017

Member

This comment from #14289 is a direct confirmation by the issue reporter that d2k-d works (apparently under MacOS).

Member

penev92 commented Nov 28, 2017

This comment from #14289 is a direct confirmation by the issue reporter that d2k-d works (apparently under MacOS).

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 29, 2017

Member

And this comment from #14319 is a direct confirmation by the issue reporter that d2k-e works (apparently under both Linux and Windows).

Member

penev92 commented Nov 29, 2017

And this comment from #14319 is a direct confirmation by the issue reporter that d2k-e works (apparently under both Linux and Windows).

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 29, 2017

Member

With the above two comments I now consider this pretty easy to review.

Member

penev92 commented Nov 29, 2017

With the above two comments I now consider this pretty easy to review.

@reaperrr

Although confirmation that they work on linux would be nice, since all of them have been tested and verified as working by at least 1 tester and can only improve the installer situation and not regress anything, I'll just give this the benefit of the doubt 👍

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Nov 30, 2017

Member

Note that I myself have tested all of them on Windows ;)
We now have confirmation for 2 of the 3 that they work on mac/linux by the people that originally complained that they can't install from their CDs.

Member

penev92 commented Nov 30, 2017

Note that I myself have tested all of them on Windows ;)
We now have confirmation for 2 of the 3 that they work on mac/linux by the people that originally complained that they can't install from their CDs.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 1, 2017

Contributor

Ah whatever, I'll count those confirmations from other people as 👍

Contributor

reaperrr commented Dec 1, 2017

Ah whatever, I'll count those confirmations from other people as 👍

@reaperrr reaperrr merged commit 77ae802 into OpenRA:bleed Dec 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment