New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Update some prerequisites to include subfactions too #14459

Merged
merged 1 commit into from Dec 23, 2017

Conversation

Projects
None yet
3 participants
@MustaphaTR
Member

MustaphaTR commented Nov 30, 2017

Now this is a bit problematic, because stuff in original game are a bit incosistent. So i only added some of them.

This PR only makes Combat Tanks, Raiders, Trikes and Missile Tanks available to subfactions they should be.

In original, factions with specific war factories (Corrino (just code level, no specific artwork) and Mercenaries) can't build their IX specific units. But others (Fremen and Smugglers) can. I didn't touch them, none are available to subfactions currently.

Similar can be said for Palace units. I didn't touch to them and ornithopter either.

On TibEd, none of Palace, Hi-Tech Factory or IX Tier special units lists subfactions for their owners.

This PR probably makes some mission map specific code unnecessary. I'll add a commit that removes them later when i find time too.

@MustaphaTR MustaphaTR referenced this pull request Dec 10, 2017

Merged

D2K - Add Harkonnen 8 #14427

@@ -648,6 +660,15 @@ starport:
ProvidesPrerequisite@harkonnen:
Prerequisite: starport.harkonnen
Factions: harkonnen
ProvidesPrerequisite@atreides_combat:
Prerequisite: starport.atreides_combat

This comment has been minimized.

@ltem

ltem Dec 13, 2017

Contributor

What is the purpose of starport.atreides_combat? If it is for the combat tanks in the starport.yaml, they are already by starport.atreides (Link).

@ltem

ltem Dec 13, 2017

Contributor

What is the purpose of starport.atreides_combat? If it is for the combat tanks in the starport.yaml, they are already by starport.atreides (Link).

This comment has been minimized.

@ltem

ltem Dec 14, 2017

Contributor

Ahh sorry, I searched for it for sure but somehow screwed up.

@ltem

ltem Dec 14, 2017

Contributor

Ahh sorry, I searched for it for sure but somehow screwed up.

@ltem

ltem approved these changes Dec 14, 2017

@ltem ltem added the PR: Needs +2 label Dec 14, 2017

@pchote

pchote approved these changes Dec 23, 2017

Looks reasonable, but I trust from your and @ltem's testing that the missions haven't regressed.

@pchote pchote merged commit 65e4019 into OpenRA:bleed Dec 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-subfaction-prerequisites branch Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment