Unhardcode some AI squad scan radii and misc AI improvements #14466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Dec 2, 2017
| // If there are any own buildings within the DangerRadius, don't flee | ||
| // PERF: Avoid LINQ | ||
| foreach (var u in units) | ||
| { |
There was a problem hiding this comment.
Braces around single line statements.
|
This looks like the solution of the issues I have with the AI since the isometric-range-rescale PR, so yes, pretty please fix the code issue. |
reaperrr
force-pushed
the
misc-AI-improvements
branch
from
3caab76
to
3fe15de
Compare
|
Updated. |
pchote
reviewed
Dec 28, 2017
|
|
||
| for (var i = 0; i < x; i += DangerRadius * 2) | ||
| for (var i = 0; i < x; i += dangerRadius * 2) |
There was a problem hiding this comment.
Manually chunking the map like this is really awful 😢
In the future we could win a lot of simplicity and perf by maintaining spatially partitioned maps of targetability and danger for each squad class.
pchote
approved these changes
Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased configurability, improved disabled-trait-awareness and minor (though likely negligible) performance optimization.
Note: Intentionally didn't touch AirStates here, I'll wait for #14387 to be merged first.