New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a screen map visualization overlay #14473

Merged
merged 2 commits into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Dec 3, 2017

This makes it easy to see and test the various issues with screen map rectangles (especially in TS), and will significantly simplify testing of the ScreenMap rewrite PR.

@pchote pchote added this to the Next release milestone Dec 3, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 3, 2017

Contributor

OpenRA.Game/Graphics/WorldRenderer.cs:L217: [SP2100] Code line must be no longer than 180 characters (now 188).

Contributor

reaperrr commented Dec 3, 2017

OpenRA.Game/Graphics/WorldRenderer.cs:L217: [SP2100] Code line must be no longer than 180 characters (now 188).

@penev92

Looks quite helpful 👍
Also produces some really strange results, especially in TS.
Sandworm looks awesome with this enabled :P

@@ -57,6 +63,11 @@ public void InvokeCommand(string name, string arg)
debugVis.RenderGeometry ^= true;
break;
case "showscreenmap":
if (devMode == null || devMode.Enabled)

This comment has been minimized.

@penev92

penev92 Dec 4, 2017

Member

Why add the extra dependency to make a special snowflake out of this when none of the others are doing it?

@penev92

penev92 Dec 4, 2017

Member

Why add the extra dependency to make a special snowflake out of this when none of the others are doing it?

This comment has been minimized.

@pchote

pchote Dec 4, 2017

Member

This one displays the positions of every actor on the map, ignoring shroud/fog/cloak/etc. The others can't be used maliciously to cheat.

@pchote

pchote Dec 4, 2017

Member

This one displays the positions of every actor on the map, ignoring shroud/fog/cloak/etc. The others can't be used maliciously to cheat.

This comment has been minimized.

@penev92

penev92 Dec 4, 2017

Member

Thought so, so I checked the rest. The CombatDebugOverlay also works through fog, but not shroud (kinda odd). Maybe we should fix that?
Also if this is intended to not let me enable the overlay through the chat command without turning on "cheats", then I don't think it worked. :/

@penev92

penev92 Dec 4, 2017

Member

Thought so, so I checked the rest. The CombatDebugOverlay also works through fog, but not shroud (kinda odd). Maybe we should fix that?
Also if this is intended to not let me enable the overlay through the chat command without turning on "cheats", then I don't think it worked. :/

This comment has been minimized.

@pchote

pchote Dec 4, 2017

Member

Cheats are force enabled on any game with only one real person.

@pchote

pchote Dec 4, 2017

Member

Cheats are force enabled on any game with only one real person.

@penev92 penev92 added the PR: Needs +2 label Dec 4, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 4, 2017

Member

Fixed stylecop nit.

Member

pchote commented Dec 4, 2017

Fixed stylecop nit.

@reaperrr reaperrr merged commit 9d29359 into OpenRA:bleed Dec 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:screenmap-vis branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment