Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix enabled trait checks #14477
referenced this pull request
Dec 7, 2017
This doesn't seem to work, am I missing something obvious?
My testcase is:
diff --git a/mods/d2k/rules/infantry.yaml b/mods/d2k/rules/infantry.yaml index b83312be0b..36622c31a1 100644 --- a/mods/d2k/rules/infantry.yaml +++ b/mods/d2k/rules/infantry.yaml @@ -98,7 +98,11 @@ thumper: Mobile: Speed: 43 RequiresCondition: undeployed + GrantConditionOnTerrain: + Condition: enable-deploy + TerrainTypes: Sand, Spice, Dune, SpiceSand GrantConditionOnDeploy: + RequiresCondition: enable-deploy DeployedCondition: deployed UndeployedCondition: undeployed Facing: 128
which should disable the thumper deploy when it is not on sand. The no-deploy cursor shows as expected, so the problem appears to be with the commandbar changes in this PR. Note that this depends on #14482 to fix the invisible thumper regression. I plan on PRing this testcase as a polish fix once this and #14482 are merged.