New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider BuildAtProductionType for exit types too for normal ProductionQueue #14508

Merged
merged 1 commit into from Dec 27, 2017

Conversation

Projects
None yet
5 participants
@MustaphaTR
Member

MustaphaTR commented Dec 14, 2017

Noticed while trying to use exit types on my mod, which uses ProductionQueue trait.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 18, 2017

Contributor

Needs rebase.

Contributor

reaperrr commented Dec 18, 2017

Needs rebase.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 18, 2017

Member

Rebased.

Member

MustaphaTR commented Dec 18, 2017

Rebased.

@GraionDilach

👍

@pchote pchote added the PR: Needs +2 label Dec 27, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 27, 2017

Member

Something to bear in mind for the future is to please try and keep the first line of commit messages under 70 characters so that they aren't truncated. You can then put two new lines and a descriptive body if you need to give more info.

Member

pchote commented Dec 27, 2017

Something to bear in mind for the future is to please try and keep the first line of commit messages under 70 characters so that they aren't truncated. You can then put two new lines and a descriptive body if you need to give more info.

@pchote

pchote approved these changes Dec 27, 2017

@pchote pchote merged commit acf2535 into OpenRA:bleed Dec 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:fix-exit-build-at-normal-prod-queue branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment