New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak when playing videos #14510

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Dec 14, 2017

By inspection, playing a second video does not release the audio for the first video.

Disclaimer: I have not tested this as I lack videos to test with - would be nice if somebody could verify it, but hopefully it's straightforward enough anyway.

@pchote pchote added this to the Next release milestone Dec 14, 2017

@pchote

pchote approved these changes Dec 18, 2017

@pchote pchote added the PR: Needs +2 label Dec 18, 2017

@abcdefg30 abcdefg30 merged commit 5d8c9a5 into OpenRA:bleed Dec 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 18, 2017

@RoosterDragon RoosterDragon deleted the RoosterDragon:video-audio-cleanup branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment