New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid LINQ in some key methods. #14528

Merged
merged 3 commits into from Dec 17, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Dec 16, 2017

Avoid LINQ in some commonly called Tick methods, and also avoid it when building map domains as this generates a lot of needless work for the GC when loading.

RoosterDragon added some commits Dec 15, 2017

Avoid LINQ in some Tick methods.
As Tick is called often, avoiding allocation overhead in these methods is useful.
@pchote

pchote approved these changes Dec 16, 2017

@pchote pchote added the PR: Needs +2 label Dec 16, 2017

@pchote pchote added this to the Next release milestone Dec 16, 2017

@reaperrr reaperrr merged commit bf21fc5 into OpenRA:bleed Dec 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RoosterDragon RoosterDragon deleted the RoosterDragon:avoid-linq branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment