Presize MemoryStream when possible. #14529
Conversation
OpenRA.Game/Network/Order.cs
Outdated
| @@ -240,7 +240,7 @@ public byte[] Serialize() | |||
| { | |||
| if (IsImmediate) | |||
| { | |||
| var ret = new MemoryStream(); | |||
| var ret = new MemoryStream(1 + OrderString.Length + TargetString.Length); | |||
There was a problem hiding this comment.
w.Write(string) includes a length prefix so this is always at least two too few bytes, but possibly more if the strings are long!
There was a problem hiding this comment.
Being wrong isn't the end of the world, the stream can still resize. This just gets us in the right ballpark. Alternatively, I could remove it if it's misleading.
There was a problem hiding this comment.
How about we change this to 3 + OrderString.Length + TargetString.Length? That will be correct so long as both strings are less than 255 characters, which should be the most common case.
There was a problem hiding this comment.
Done. Spelt it 1 + OrderString.Length 1 + TargetString.Length + 1 so it ties up with the things we're writing out like the other call-sites.
OpenRA.Game/Server/ServerOrder.cs
Outdated
| @@ -49,7 +49,7 @@ public static ServerOrder Deserialize(BinaryReader r) | |||
|
|
|||
| public byte[] Serialize() | |||
| { | |||
| var ms = new MemoryStream(); | |||
| var ms = new MemoryStream(1 + Name.Length + Data.Length); | |||
Also use GetBuffer when we know we have presized the stream to the exact required size to prevent a needless copy.
RoosterDragon
force-pushed
the
memory-stream-presize
branch
from
fbf7fce
to
23b2759
Compare
Also use GetBuffer when we know we have presized the stream to the exact required size to prevent a needless copy.
Helps with #14178 by reducing allocations during loading (the main culprits are ZipFile and MixFile), decreasing the peak memory reached when loading. The other stuff is mostly just along for the ride. :)