New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute map UIDs without copying all data to a MemoryStream. #14530

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
3 participants
@RoosterDragon
Member

RoosterDragon commented Dec 16, 2017

We can use MergedStream to create a single combined stream with all the input and pass this to the hash function. This saves copying all the data into a MemoryStream to achieve the same goal, which requires more memory and allocations.

Helps with #14178 by reducing allocations during loading, decreasing the peak memory reached when loading.

Compute map UIDs without copying all data to a MemoryStream.
We can use MergedStream to create a single combined stream with all the input and pass this to the hash function. This saves copying all the data into a MemoryStream to achieve the same goal, which requires more memory and allocations.
@pchote

pchote approved these changes Dec 16, 2017

@pchote pchote added the PR: Needs +2 label Dec 16, 2017

@pchote pchote added this to the Next release milestone Dec 16, 2017

@reaperrr reaperrr merged commit be761de into OpenRA:bleed Dec 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RoosterDragon RoosterDragon deleted the RoosterDragon:map-uid-merge-streams branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment