New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly named lobby option properties. #14532

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Dec 16, 2017

Fixes an oversight from #14359 - I somehow managed to accidentally discard the rule changes associated with the requested renames. This PR fixes the order of the lobby options and reenables cheats by default in TS.

@pchote pchote added this to the Next release milestone Dec 16, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 17, 2017

Contributor

One question, though: Could it be that D2k also had Limit Build Area at some point? I faintly remember one mod used to have 8 checkboxes instead of 7, but I'm not sure.

Contributor

reaperrr commented Dec 17, 2017

One question, though: Could it be that D2k also had Limit Build Area at some point? I faintly remember one mod used to have 8 checkboxes instead of 7, but I'm not sure.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 17, 2017

Member

It did at one point, but it was removed when we made the push to match it with the original game. The map designs force a naturally limited build area without requiring the radius.

Member

pchote commented Dec 17, 2017

It did at one point, but it was removed when we made the push to match it with the original game. The map designs force a naturally limited build area without requiring the radius.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Dec 17, 2017

Contributor

Does the TD mod even use BuildProvider? If no, then there isn't a point in exposing the buildradius checkbox.

Contributor

GraionDilach commented Dec 17, 2017

Does the TD mod even use BuildProvider? If no, then there isn't a point in exposing the buildradius checkbox.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 17, 2017

Member

TD does, yes. BuildProvider was originally created for TD.

D2K doesn't, and the checkbox isn't exposed there.

Member

pchote commented Dec 17, 2017

TD does, yes. BuildProvider was originally created for TD.

D2K doesn't, and the checkbox isn't exposed there.

@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92

penev92 Dec 17, 2017

Member

I really hope we're not missing some maps with custom rules, but I couldn't find any, so fingers crossed.

Member

penev92 commented Dec 17, 2017

I really hope we're not missing some maps with custom rules, but I couldn't find any, so fingers crossed.

@penev92 penev92 merged commit 49f0e4e into OpenRA:bleed Dec 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@penev92

This comment has been minimized.

Show comment
Hide comment
@penev92
Member

penev92 commented Dec 17, 2017

@pchote pchote deleted the pchote:fix-lobby-options-layout branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment