New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExternalCapture footprint/targetable position mismatch. #14539

Merged
merged 2 commits into from Dec 18, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Dec 17, 2017

Fixes #14275.

The problem was that ExternalCaptureActor used NearestCellTo which was based on the actor's cell footprint, while MoveAdjacentTo used Util.AdjacentCells which is based on the actor's targetable positions. Util.AdjacentCells is the more correct option in all cases.

pchote added some commits Dec 17, 2017

Use Util.AdjacentCells to determine ExternalCapture validity.
This matches the set of cells targeted by MoveAdjacentTo.

@pchote pchote added this to the Next release milestone Dec 17, 2017

@Smittytron

Works as advertised.

@pchote pchote merged commit e35e935 into OpenRA:bleed Dec 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:fix-externalcapture-footprint branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment