New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the multiplayer menu UI #14563

Merged
merged 4 commits into from Dec 24, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Dec 22, 2017

The discussion and subsequent removal of the ingame IRC client raised some points that we need to finish addressing before the playtest. This PR makes a start by addressing two points:

  • The tabbed layout (and size/shape constraints that imposed) doesn't make sense without the chat to tie them together.
  • Many players don't understand port forwarding.

This effectively reverts #9744.

screen shot 2017-12-22 at 14 48 43
screen shot 2017-12-22 at 16 52 56
screen shot 2017-12-22 at 16 53 46
screen shot 2017-12-22 at 17 01 49
screen shot 2017-12-22 at 16 53 15

@pchote pchote added this to the Next release milestone Dec 22, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 22, 2017

Member

Once this is merged a followup PR will add a player list to the MP browser, which is the main motivation for this exercise:
screen shot 2017-12-22 at 16 44 17

Member

pchote commented Dec 22, 2017

Once this is merged a followup PR will add a player list to the MP browser, which is the main motivation for this exercise:
screen shot 2017-12-22 at 16 44 17

@reaperrr

Layout looks good to me, all dialogs seems to work as intended, mod switching still works

pchote added some commits Dec 17, 2017

Remove secondary AllowPortForward setting.
The global setting is fine, and this simplifies
both the code and the UI.
Restore separated server creation dialog.
This also adds details about advertising and configuration.
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 23, 2017

Member

Updated.

Member

pchote commented Dec 23, 2017

Updated.

@abcdefg30 abcdefg30 merged commit 0b44616 into OpenRA:bleed Dec 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 24, 2017

@pchote pchote deleted the pchote:multiplayer-ui branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment