New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProductionOverlay crash. #14574

Merged
merged 1 commit into from Dec 25, 2017

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Dec 25, 2017

WithProductionOverlay was still assuming the old behaviour for ProductionQueue.Enabled (set once during creation, then never touched), which was changed by #14387. This makes the queue filtering dynamic so that the overlay is disabled if there queues themselves haven't been initialized yet.

Fixes #14573.

@pchote pchote added this to the Next release milestone Dec 25, 2017

@pchote pchote referenced this pull request Dec 25, 2017

Merged

D2K - Add Harkonnen 8 #14427

@reaperrr

Not tested, but code looks good to me

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 25, 2017

Contributor

Maybe @MustaphaTR or @ltem could test this, I won't have time until tomorrow.

Contributor

reaperrr commented Dec 25, 2017

Maybe @MustaphaTR or @ltem could test this, I won't have time until tomorrow.

@MustaphaTR

I have hit another issue with Har8 but this is fixing the crash at #14573.

@ltem

ltem approved these changes Dec 25, 2017

Tested as well and it fixed the issue.

@ltem ltem merged commit ec97214 into OpenRA:bleed Dec 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem
Contributor

ltem commented Dec 25, 2017

@pchote pchote deleted the pchote:fix-productionoverlay-crash branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment