New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outdated/unknown version and new playtest notices to the MP server browser. #14581

Merged
merged 2 commits into from Dec 28, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Dec 26, 2017

This replaces yet another failed usecase of the ingame IRC with a better integrated solution.
Banners are displayed at the top of the server list if the player is running an outdated or unknown version of our default mods, or if they are running the latest version and a playtest is available.

notices

Depends on #14571.

The master server will only give notices for our ra, cnc, and d2k mods. Other mods must change MPNotices in mod.yaml to point at their own backend if they want to use this.

I have set up a placeholder backend service to help with testing:

  • A new playtest notice is given for d2k version release-20171014.
  • No notices are given for other the other mods on release-20171014.
  • An outdated version notice is given if the version otherwise starts with release- or playtest-.

I will PR the final backend against the master server after this and the outstanding protocol rewrite PRs have been merged. It will work by fetching a JSON file from https://github.com/OpenRA/OpenRAWeb that contains lists of current and outdated versions.

@pchote pchote added this to the Next release milestone Dec 26, 2017

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 26, 2017

Contributor

Needs rebase.

Contributor

reaperrr commented Dec 26, 2017

Needs rebase.

pchote added some commits Dec 26, 2017

Display information banners in the MP server browser.
Notices are provided for outdated / unknown mod versions
and latest but playtest available.
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 26, 2017

Member

Rebased.

Member

pchote commented Dec 26, 2017

Rebased.

@pchote pchote removed the PR: Rebase me! label Dec 26, 2017

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Dec 27, 2017

Contributor

Other mods must change MPNotices in mod.yaml to point at their own backend if they want to use this.

The fallback link within the PR doesn't provide an example, however. I presume there will be documentation on this after the release?

Contributor

GraionDilach commented Dec 27, 2017

Other mods must change MPNotices in mod.yaml to point at their own backend if they want to use this.

The fallback link within the PR doesn't provide an example, however. I presume there will be documentation on this after the release?

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 27, 2017

Member

Yeah, and the source code for the server side will be available too.

Member

pchote commented Dec 27, 2017

Yeah, and the source code for the server side will be available too.

@GraionDilach

LGTM then, since that was my only complaint.

@reaperrr reaperrr merged commit 27beed4 into OpenRA:bleed Dec 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 29, 2017

Member

See OpenRA/OpenRAMasterServer#50 and OpenRA/OpenRAWeb#369 for the server side parts of this.

Member

pchote commented Dec 29, 2017

See OpenRA/OpenRAMasterServer#50 and OpenRA/OpenRAWeb#369 for the server side parts of this.

@pchote pchote deleted the pchote:multiplayer-version-check branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment